Modification of tag transmission from edges to faces in analysis

[coprigent]

In function MMG5_bdrySet, if all three edges of a face share a given tag, this tag is given to the face (field xt->ftag[]). Some edge tags do not make sense when applied to a face (MG_GEO or/and MG_NOM). This could cause bugs in splits when a newly create edge wrongly received such tags from a face. This update removes such nonsensical tags.

[codecov]

Codecov Report

Attention: Patch coverage is 68.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 50.45%. Comparing base (5a73683) to head (7de7e10).

Files	Patch %	Lines
src/mmg3d/chkmsh_3d.c	50.00%	2 Missing and 3 partials ⚠️
src/mmg3d/hash_3d.c	80.00%	3 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           develop     #277   +/-   ##
========================================
  Coverage    50.44%   50.45%           
========================================
  Files          176      176           
  Lines        47200    47222   +22     
  Branches     10261    10265    +4     
========================================
+ Hits         23811    23825   +14     
- Misses       15664    15669    +5     
- Partials      7725     7728    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Algiane]

Thanks,
Please, can you check my comments and rerun the ParMmg checks with the suitable fix if it makes sense ?
Best

[Algiane]

Thanks,

Just a small note: If we really wanted to do things properly, we would have had to add 3 unit tests to cover this line: each of the tests calling the function on a hard-defined tetra with one of the erroneous tags on one of its faces. The test would be considered as successful if it fails inside the assertion in debug mode.