Feature/bdy edge interp #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an assertion to ensure that no boundary edge is seen as internal during anisotropic metric interpolation. Note that some ci tests are failing because indeed, some boundary edges are not detected as boundary.
Algiane
added
kind: bug
|
Output results for attached CMake configuration are provided in the Differences in results are due to the fact that previously missing boundary edge tags are now added to boundary edges. It leads to authorize collapses previously no tested due to the following test (the temporary |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix errouneous boundary tag checking in
interp_anifunction (leading to interpolate the metric along boundary edges as if the edge was an internal one).It is related to the PR #234 and #236.
Note that I am not sure of some of the assertions that have been added (maybe too strict) : for example, test here supposes that we can enter the current function without a xtetra. In this case, added assert is probably wrong.