Modification of the settag function #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The settag function updates tag info by travelling the tetra of the shell of a given edge. Commit 0f487e0 (which aims to add the support of required entities) has introduced the fact that the edge tag is updated only for tetra in which the edge belongs to a boundary face. Thus, if the edge has no boundary face, it is not updated. It may leads to tag inconsistencies in ParMmg where the settag function is called (in `cleanMesh`function) and where edges not belonging to bdy faces may be marked as MG_BDY. As a recall: - any edge marked as MG_BDY has to have consistent tags with the tags of the same edge in the other tetra. - regular edges belonging to a boundary face inside the current tet may have a 0 tag (because for now the splitting operators are creating boundary edges with 0 tags when splitting boundary triangles, see split_3d.c). - regular or non regular edges not having a bdy face inside the tetra may have a 0 tag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
The settag function updates tag info by travelling the tetra of the shell of a given edge. Commit 0f487e0 (which aims to add the support of required entities) has introduced the fact that the edge tag is updated only for tetra in which the edge belongs to a boundary face.
Thus, if the edge has no boundary face, it is not updated.
It may leads to tag inconsistencies in ParMmg where the settag function is called (in
cleanMeshfunction).and where edges not belonging to bdy faces may be marked as MG_BDY.
As a recall:
Resolution
Now the edge tag is updated for all the tetra of the shell that have a xtetra.
Check for regression
This modification has been tested by running, in Debug mode, the continuous integration tests that contains required entities (
Reqpattern in test name) and the tests related to the nosurf option (nosurfpattern) : the adaptation waves are the same.Remark: Comparative outputs may contains useless 2D or surface tests due to the usage of the regex.
old-nosurf.txt
new-nosurf.txt
old-req.txt
new-req.txt