Iter18 #36
Open
Iter18 #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nter and gauge metrics, storages and type conversion methods.
…mat string and no further arguments should use print-style function instead
…tp://localhost:8080/update/counter/testCounter/100 -> Delete 415 response from unsupported content type.
…ime, custom, agregate), hardWorker. Added basic test for all module.
…ge github.com/MlDenis/prometheus_wannabe/cmd/html; to add it: go get github.com/MlDenis/prometheus_wannabe/cmd/html # github.com/MlDenis/prometheus_wannabe/internal/metrics internal/metrics/agregateMetricsProvider.go:31:4: fmt.Println call has possible formatting directive %v internal/metrics/customMetricsProvider.go:32:2: fmt.Println call has possible formatting directive %v internal/metrics/customMetricsProvider.go:35:2: fmt.Println call has possible formatting directive %v internal/metrics/runtimeMetricsProvider.go:41:3: fmt.Printf format %V has unknown verb V.
…ge github.com/MlDenis/prometheus_wannabe/cmd/html; to add it: go get github.com/MlDenis/prometheus_wannabe/cmd/html.
…ting directive %v.
…gnment mismatch: 1 variable but NewHTTPMetricsAgent returns 2 values
…начнут поступать данные: context deadline exceeded.
…ords are written.
…mmented out code.
…de in favor of queries in methods.
…age collection in httpMetricsSendler.
Changed the cpuUtilizationMetrics type to slice instead of map. Changed cpuInterval to a constant. The updateCPUMetrics function now checks that index i does not exceed the length of cpuUtilizationMetrics.
Instead of returning an error immediately after receiving it, error handling is implemented directly in the loop. Instead of logging every metric update, only errors are logged.
…g specific errors instead of wrapping them.
Rename profile dirrectory to profiles. Go version up to 1.21.5. Add result.pprof.
Rename profile dirrectory to profiles. Add result.pprof.
Used the goimports utility to correct imports in the project.
Added documentation in year format to the main exported methods and variables (handlers, public structures and interfaces). Added an example of working with practical track endpoints in the example_test.go format.
| "github.com/sirupsen/logrus" | ||
| ) | ||
|
|
||
| type Config struct { |
There was a problem hiding this comment.
К конфигу хорошо бы дать комментарии или доку, важная часть
| }) | ||
| } | ||
|
|
||
| func (p *postgresDataBase) ReadItem(ctx context.Context, metricType string, metricName string) (*database.DBItem, error) { |
There was a problem hiding this comment.
Как и ко всем публичным методам
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.