Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: absolute url in version selector to avoid 404 errors (1 of 2) #2835

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

tbreuss
Copy link
Contributor

@tbreuss tbreuss commented May 2, 2023

Fixes #2832 (1 of 2 pull requests)

Copy link
Member

@dead-claudia dead-claudia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved contingent on #2832 being merged first (and obviously, no release occuring before it). That way we can guarantee we won't have more of these to fix.

@tbreuss tbreuss changed the title docs: in version selector fixed wrong archive links in archived versions docs: Make url of version changer absolute to avoid 404 errors May 5, 2023
@tbreuss tbreuss changed the title docs: Make url of version changer absolute to avoid 404 errors docs: make url of version changer absolute to avoid 404 errors May 5, 2023
@tbreuss tbreuss changed the title docs: make url of version changer absolute to avoid 404 errors docs: make url of version switcher absolute to avoid 404 errors May 5, 2023
@tbreuss tbreuss changed the title docs: make url of version switcher absolute to avoid 404 errors docs: make url of version selector absolute to avoid 404 errors May 5, 2023
@tbreuss tbreuss changed the title docs: make url of version selector absolute to avoid 404 errors docs: make url of version selector absolute to avoid 404 errors (1 of 2 prs) May 5, 2023
@tbreuss
Copy link
Contributor Author

tbreuss commented May 5, 2023

Approved contingent on #2832 being merged first (and obviously, no release occuring before it). That way we can guarantee we won't have more of these to fix.

@dead-claudia FYI: I extracted the small fix for the document generator from the big "website cleanup" branch. So we have two pull requests now, that solve the problem with 404 not found errors and can be reviewed and merged.

But, the first pull request to be merged should be #2835. The reason is, that this pull request fixes the current website too, as far as I understand the publishing and archiving process.

Then, we can merge the second pull request #2839. This fixes the issue for future releases.

So, IMHO the order should be like:

Maybe I'm wrong. But in this case the order can be changed easily.

@tbreuss tbreuss changed the title docs: make url of version selector absolute to avoid 404 errors (1 of 2 prs) docs: absolute url in version selector to avoid 404 errors (1 of 2 prs) May 6, 2023
@tbreuss tbreuss changed the title docs: absolute url in version selector to avoid 404 errors (1 of 2 prs) docs: absolute url in version selector to avoid 404 errors (1 of 2) May 6, 2023
@dead-claudia dead-claudia merged commit 2089b7a into MithrilJS:gh-pages Jul 31, 2023
@JAForbes JAForbes mentioned this pull request Jul 31, 2023
This was referenced Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants