Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2025 array of querystring without number #2053

Closed
wants to merge 3 commits into from

Conversation

alfa-jpn
Copy link

Description

This is WIP about issue #2025.

Motivation and Context

Please reference issue #2025.

How Has This Been Tested?

var querystring = m.buildQueryString({a: ["hello", "world"]})
// querystring is "a[]=hello&a[]=world"

m.parseQueryString("a[]=hello&a[]=world")
// data is {a: ["hello", "world"]}

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
    • remove index from array querystring
    • unsupport nest array ex) { a: [["x"], ["y"]] } // a[0][0]=x&a[1][0]=y

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated docs/change-log.md

@alfa-jpn alfa-jpn requested a review from tivac as a code owner December 10, 2017 12:38
@pygy pygy added the m.request label Dec 10, 2017
@pygy pygy added this to the 2.0.0 milestone Dec 10, 2017
@alfa-jpn alfa-jpn changed the title [WIP] #2025 array of querystring without number #2025 array of querystring without number Feb 25, 2018
@dead-claudia dead-claudia modified the milestones: 2.0.0, post-v2 Sep 25, 2018
@dead-claudia dead-claudia added the Type: Breaking Change For any feature request or suggestion that could reasonably break existing code label Oct 28, 2018
@dead-claudia dead-claudia removed this from the post-v2 milestone Jul 24, 2019
@StephanHoyer
Copy link
Member

@alfa-jpn would you mind rebasing your change onto the current version? I think we are ready to merge this now

@dead-claudia dead-claudia removed the request for review from tivac February 7, 2023 06:04
@dead-claudia dead-claudia requested a review from a team as a code owner September 23, 2024 11:58
@dead-claudia dead-claudia deleted the branch MithrilJS:next September 25, 2024 05:23
@dead-claudia
Copy link
Member

Closed due to the next branch being deleted. I'll let someone else recreate this PR against the current main instead, if it's of sufficient demand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major Type: Breaking Change For any feature request or suggestion that could reasonably break existing code
Projects
Status: Completed/Declined
Development

Successfully merging this pull request may close these issues.

4 participants