Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent looping when no closing parenthesis is found #418

Merged
merged 2 commits into from
Feb 18, 2024

Conversation

Loottoo
Copy link
Contributor

@Loottoo Loottoo commented Feb 18, 2024

linterOops
The argumentsString variable builds up to extreme lengths when argumentClosing is -1 (no closing parenthesis).

Reproduce with code:

rule("Each Player Rule")
{
    event
    {
        Ongoing - Each Player;
        All;
        All;
    }

    conditions
    {

    }

    actions
    {
	    Apply Impulse(Event Player, Dot Product(Velocity Of(
	    Event Player), Normalize(X Component Of(Throttle))

        
    }
}

The argumentsString variable builds up to extreme lenghts when argumentClosing is -1 (no closing parenthesis)
remove clamps

Co-authored-by: Martín Rodríguez <[email protected]>
@Mitcheljager Mitcheljager merged commit 08a4ef0 into Mitcheljager:master Feb 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants