fix: Include special characters in syntax highlighting #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you give ChatGPT a list with the name of all heroes and asked it to give you the range of characters their names contain? Everything in red is being captured by the new ranges. Do we really need Ø and ø? |
|
@netux I didn't, no. I just asked it to accept characters with accents. I suppose we don't really need those characters, but they don't hurt either I suppose |
In that case then why not add the rest of the latin alphabet? 😅 |
|
@netux Because I didn't think of it! Updated it |
netux
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keywords with special accents were not being highlighted as expected. This PR fixes that by including these characters in the regex. It's a bit of a ChatGPT special, but it seems to work well.