Editor: @for loop custom step size #401

netux · 2024-01-28T21:31:28Z

This PR adds an optional step size to @for loops (instead of the default: 1), active when using the in steps of operator.

Example

@for (0 through 4 in steps of 2) {
  For.i;
}

Renders:

  0;
  2;
  4;

@for

…loops Allows for the following syntax: ``` @for (0 through 4 in steps of 2) { For.i; } ``` Printing: ``` 0; 2; 4; ```

Since this operator uses spaces, I also had to change `customOperators` from a word set to a regular expression.

@for

…ng a @for loop with a custom step size Use the "to"/"through" as a delimiter for where we should check. If to the left there is no "from", then warn the user.

Mitcheljager

Cool! It's a bit overkill since you can just do For.i * x, but it's also kinda fun, so why not! I did have a couple of nitpicks though

Mitcheljager · 2024-01-28T21:51:47Z

app/javascript/src/lib/OWLanguageLegacy.js

@@ -58,6 +58,7 @@ function tokenBase(stream, state) {
  if (stream.match(hexadecimal)) return "number"
  if (stream.match(decimal)) return "number"
  if (stream.match(customKeywords)) return "atom"
+  if (stream.match(customOperators)) return "atom"


Hopefully it wasn't down below for a reason :D

I think it was just leeching off the identifier regex.

app/javascript/src/lib/OWLanguageLinter.js

app/javascript/src/utils/compiler/for.js

Co-authored-by: Mitchel Jager <[email protected]>

netux · 2024-01-28T22:20:39Z

It's a bit overkill since you can just do For.i * x

Yes, but that means outputting (whatever value For.i was) * x, which means more elements in the Workshop. So this should help with (micro-)optimization.

For simple cases I also found you can do a mixin like the one below, though its less readable/more verbose.

@mixin map01To(value, ifZero, ifOne) { @if (Mixin.value == 0) { Mixin.ifZero } @else { Mixin.ifOne } }

// This is meant to go through 0 to 2, skipping 1
@for (0 through 1) {
  @include map01To(For.i, 0, 2)
}

netux added 3 commits January 28, 2024 18:19

feat(editor compiler): allow for specifying a custom step size in @for …

42851bd

…loops Allows for the following syntax: ``` @for (0 through 4 in steps of 2) { For.i; } ``` Printing: ``` 0; 2; 4; ```

feat(editor highlighter): add "in steps of" as a custom operator

54cfc18

Since this operator uses spaces, I also had to change `customOperators` from a word set to a regular expression.

fix(editor linter): adjust checkForLoops() to not throw when checki…

f32deb3

…ng a @for loop with a custom step size Use the "to"/"through" as a delimiter for where we should check. If to the left there is no "from", then warn the user.

Mitcheljager requested changes Jan 28, 2024

View reviewed changes

netux and others added 2 commits January 28, 2024 19:13

style(editor linter): surround if-statement with brackets

d2f6b9f

Co-authored-by: Mitchel Jager <[email protected]>

style(editor compiler): expand abbreviations in variable names

ccb1e73

Mitcheljager approved these changes Feb 1, 2024

View reviewed changes

Mitcheljager merged commit 11f6162 into Mitcheljager:master Feb 1, 2024
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Editor: @for loop custom step size #401

Editor: @for loop custom step size #401

netux commented Jan 28, 2024

Mitcheljager left a comment

Mitcheljager Jan 28, 2024

netux Jan 28, 2024

netux commented Jan 28, 2024

Editor: @for loop custom step size #401

Editor: @for loop custom step size #401

Conversation

netux commented Jan 28, 2024

Example

Mitcheljager left a comment

Choose a reason for hiding this comment

Mitcheljager Jan 28, 2024

Choose a reason for hiding this comment

netux Jan 28, 2024

Choose a reason for hiding this comment

netux commented Jan 28, 2024