Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Asset lookup registration rework #15

Merged
merged 4 commits into from
Nov 13, 2021
Merged

Asset lookup registration rework #15

merged 4 commits into from
Nov 13, 2021

Conversation

Mirsario
Copy link
Owner

Continuation of #11. In short, this branch does the following:

  • Readjusts AssetLookup registrations to happen without relation to asset loading.
  • Content sources are no longer accessed after initialization, at which asset file lists are now built.
  • IAssetReader's read method now has its stream & assetPath AssetFileEntry parameters replaced with AssetFileEntry, which has an OpenStream method and a Path field. This allows readers to create data from elsewhere, if needed.

@Mirsario Mirsario added the enhancement New feature or request label Nov 13, 2021
@Mirsario Mirsario merged commit 47a1b72 into master Nov 13, 2021
@Mirsario Mirsario deleted the asset_registration_redo branch November 13, 2021 17:20
Mirsario added a commit that referenced this pull request Feb 14, 2023
@Mirsario
Asset lookup registration rework (#15)
04581a5 
* Experiments.

* AssetFileEntry, disconnected lookup registration from autoload.

* Various fixes.

(cherry picked from commit 4f5b280182a4e5f8bbf05caa18e96e9a13284c07)

* Removed unused junk.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Mirsario