Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backup restore restructure #99

Merged
merged 13 commits into from
Oct 11, 2024
Merged

Backup restore restructure #99

merged 13 commits into from
Oct 11, 2024

Conversation

MagdaDziadosz
Copy link
Contributor

No description provided.

content/docs/operations/backup-restore/_index.md Outdated Show resolved Hide resolved
content/docs/operations/backup-restore/_index.md Outdated Show resolved Hide resolved
content/docs/operations/backup-restore/_index.md Outdated Show resolved Hide resolved
content/docs/operations/backup-restore/_index.md Outdated Show resolved Hide resolved
content/docs/operations/backup-restore/_index.md Outdated Show resolved Hide resolved
content/docs/operations/backup-restore/external.md Outdated Show resolved Hide resolved
content/docs/operations/backup-restore/external.md Outdated Show resolved Hide resolved
content/docs/operations/backup-restore/in-cluster.md Outdated Show resolved Hide resolved
content/docs/operations/backup-restore/in-cluster.md Outdated Show resolved Hide resolved
content/docs/operations/backup-restore/in-cluster.md Outdated Show resolved Hide resolved
@KoryKessel-Mirantis
Copy link
Collaborator

An FYI, @MagdaDziadosz. Due to PR102 you will need to rebase before working my comments.

content/docs/operations/backup-restore/_index.md Outdated Show resolved Hide resolved
content/docs/operations/backup-restore/_index.md Outdated Show resolved Hide resolved
content/docs/operations/backup-restore/_index.md Outdated Show resolved Hide resolved
content/docs/operations/backup-restore/external.md Outdated Show resolved Hide resolved
content/docs/operations/backup-restore/external.md Outdated Show resolved Hide resolved

Set `enable_ui` to `true` to expose the MinIO Console through the Ingress and
make it accessible through the UI. Core backup functionality works, even if
the UI is disabled. Core backup functionality works, even if the UI is disabled.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core backup functionality works, even if the UI is disabled. seems to be duplicated.

- `InCluster`, `External`
- Default: `InCluster`

`storage_provider.in_cluster_options.exposed`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the latest mkectl build exposed is removed, and should be replaced with enable_ui (which is true or false; default to true).

@@ -49,11 +54,16 @@ NAME STATUS ERRORS WARNINGS CREATED EXPIRES
test Completed 0 0 2024-05-07 17:29:18 -0400 EDT 29d default <none>
```

Optionally, you can view detailed logs of a backup by running the `mkectl
backup logs --name test` command.
To view detailed logs of a backup, run:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will actually be disabling the logs command due to some technical issues we won't have time to fix before GA. I was going to create a new PR to remove it but if you can, feel free to remove it here ( both backup logs and restore logs).

Users can view the logs via the minio UI (in in-cluster case) or S3 (in External case) - so we could replace it with a sentence pointing the users there if they wish to see the detailed logs.

Copy link
Collaborator

@tppolkow tppolkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for addressing my comments.

@KoryKessel-Mirantis
Copy link
Collaborator

@MagdaDziadosz, once you Squash and merge, please do a quick once-over of the published docs with your eagle eyes. :-)

@MagdaDziadosz MagdaDziadosz merged commit 161ed32 into main Oct 11, 2024
@MagdaDziadosz MagdaDziadosz deleted the backup-restore-restructure branch October 11, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants