-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backup restore restructure #99
Conversation
An FYI, @MagdaDziadosz. Due to PR102 you will need to rebase before working my comments. |
Co-authored-by: Kory <[email protected]>
|
||
Set `enable_ui` to `true` to expose the MinIO Console through the Ingress and | ||
make it accessible through the UI. Core backup functionality works, even if | ||
the UI is disabled. Core backup functionality works, even if the UI is disabled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Core backup functionality works, even if the UI is disabled.
seems to be duplicated.
- `InCluster`, `External` | ||
- Default: `InCluster` | ||
|
||
`storage_provider.in_cluster_options.exposed` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the latest mkectl build exposed
is removed, and should be replaced with enable_ui
(which is true or false; default to true).
@@ -49,11 +54,16 @@ NAME STATUS ERRORS WARNINGS CREATED EXPIRES | |||
test Completed 0 0 2024-05-07 17:29:18 -0400 EDT 29d default <none> | |||
``` | |||
|
|||
Optionally, you can view detailed logs of a backup by running the `mkectl | |||
backup logs --name test` command. | |||
To view detailed logs of a backup, run: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will actually be disabling the logs
command due to some technical issues we won't have time to fix before GA. I was going to create a new PR to remove it but if you can, feel free to remove it here ( both backup logs
and restore logs
).
Users can view the logs via the minio UI (in in-cluster case) or S3 (in External case) - so we could replace it with a sentence pointing the users there if they wish to see the detailed logs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for addressing my comments.
@MagdaDziadosz, once you Squash and merge, please do a quick once-over of the published docs with your eagle eyes. :-) |
No description provided.