Calculation expression#9
Open
MinyazevR wants to merge 12 commits into
Open
Conversation
yurii-litvinov
suggested changes
May 30, 2022
| public class ParsingTree | ||
| { | ||
| /// <summary> | ||
| /// abstract nested class for dividing node into operators and operands for building a parse tree |
There was a problem hiding this comment.
Везде с заглавной, а тут со строчной, неконсистентно
| /// <summary> | ||
| /// A class representing operands | ||
| /// </summary> | ||
| public class Operand : Node |
There was a problem hiding this comment.
Operand не должен быть по идее вложенным в Node, потому что а зачем :) Пусть он будет вложенным в ParsingTree
Comment on lines
+26
to
+27
| private readonly string Value; | ||
| public Operand(string element) |
There was a problem hiding this comment.
Suggested change
| private readonly string Value; | |
| public Operand(string element) | |
| private readonly string Value; | |
| public Operand(string element) |
Comment on lines
+33
to
+36
| public override float Count() | ||
| { | ||
| return float.Parse(Value); | ||
| } |
There was a problem hiding this comment.
Suggested change
| public override float Count() | |
| { | |
| return float.Parse(Value); | |
| } | |
| public override float Count() | |
| => float.Parse(Value); |
| Value = element; | ||
| } | ||
|
|
||
| // The operand class calculates the value for them and returns it |
There was a problem hiding this comment.
Комментарии с // используются только для комментариев внутри методов, тут бы ///
Но можно /// <inheritdoc /> — что комментарий наследуется от предка
Comment on lines
+7
to
+9
| { | ||
|
|
||
| /// <summary> |
There was a problem hiding this comment.
Suggested change
| { | |
| /// <summary> | |
| { | |
| /// <summary> |
| /// <summary> | ||
| /// Parse Tree Interface | ||
| /// </summary> | ||
| public interface IParsingTree |
There was a problem hiding this comment.
Он у Вас нигде не используется, следовательно не нужен
Comment on lines
+6
to
+9
| using System; | ||
|
|
||
|
|
||
| /// <summary> |
There was a problem hiding this comment.
Suggested change
| using System; | |
| /// <summary> | |
| using System; | |
| /// <summary> |
| /// <summary> | ||
| /// A class for testing a parsing tree | ||
| /// </summary> | ||
| public class TestsrsingTree |
| /// </summary> | ||
| public class TestsrsingTree | ||
| { | ||
| ParsingTree tree = new(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.