Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added traditional Chinese documents #39

Merged
merged 4 commits into from
Dec 15, 2023
Merged

Conversation

noah4520
Copy link
Contributor

πŸ”— Linked issue

N/A

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

  • Added traditional Chinese documents

πŸ“ Checklist

  • I have read the Contributing Guidelines.
  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@Mini-ghost
Copy link
Owner

Mini-ghost commented Oct 1, 2023

It's amazing! Thank you for your translation. However, clicking on the sidebar and navigation links in the Traditional Chinese document will redirect to the English document. Can you resolve it?

Maybe you can try the solution mentioned in the issue: vuejs/vitepress#631

@noah4520
Copy link
Contributor Author

noah4520 commented Oct 9, 2023

@Mini-ghost Thanks for your reply, I've fixed the issue in 902fa77.

In addition, I changed the label of Traditional Chinese from tw to zh-tw in 8f84988. I hope you will like this change.

@Mini-ghost Mini-ghost changed the title feat: Added traditional Chinese documents feat: added traditional Chinese documents Dec 15, 2023
@Mini-ghost Mini-ghost merged commit 009ff62 into Mini-ghost:main Dec 15, 2023
3 checks passed
@Mini-ghost
Copy link
Owner

This is really great! thank you for your contribution πŸ’š

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants