Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Refactor) Minor improvements to NetworkTracking #434

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

(Refactor) Minor improvements to NetworkTracking #434

wants to merge 6 commits into from

Commits on Sep 20, 2023

  1. Better handle the nested promise on response.text 

    - Returning this promise allows the parent catch block to handle the promise rejection.
    @Codex-
    Codex- committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    bec19e6 View commit details
    Browse the repository at this point in the history

  2. Feat: Migrate unused disableFetchLogging function to prototype function

    @Codex-
    Codex- committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    dace0ce View commit details
    Browse the repository at this point in the history

  3. Feat: Remove double wrapped try catch 

    - The promise started handles its own exceptions.
- The call to self.executeHandlers is already wrapped with a try catch.
    @Codex-
    Codex- committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    1db8cbc View commit details
    Browse the repository at this point in the history

  4. Feat: Remove double wrapping executeHandlers. 

    - executeHandlers has already been wrapped with wrapWithHandler.
    @Codex-
    Codex- committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    1656a5c View commit details
    Browse the repository at this point in the history

  5. Feat: Properly handle prototype assignment of originalFetch. 

    - Allows `disableFetchLogging` to function.
    @Codex-
    Codex- committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    07ed20d View commit details
    Browse the repository at this point in the history

  6. Feat: Improve the response handling flow. 

    - This gives the body being passed to the handlers more meaning.
    @Codex-
    Codex- committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    1fed759 View commit details
    Browse the repository at this point in the history