Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use modified async_kernel to extract true backtraces from monitor exns #6904

Closed
wants to merge 3 commits into from

Conversation

mrmr1993
Copy link
Member

@mrmr1993 mrmr1993 commented Dec 2, 2020

This PR

  • modifies our forked async_kernel to add a Monitor.exn_to_error function
    • this extracts the backtrace from the special hidden Monitor.Exn_for_monitor.t info inside Monitor.Error_ exceptions, wrapping it into an Error.t so our normal JSON-of-Error.t conversion can use it
    • PR at Add Monitor.exn_to_error async_kernel#5
  • uses the function to give a more accurate backtrace when crashing/handling toplevel exceptions.

This was inspired by #6901, where the Invalid_curve_point exception is very unlikely to have come from a format.ml backtrace that is shown.

Checklist:

  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them:

@mrmr1993 mrmr1993 added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Dec 2, 2020
@mrmr1993 mrmr1993 force-pushed the feature/better-crash-backtraces branch from 557f1cc to 05286ea Compare December 23, 2020 02:34
@mrmr1993 mrmr1993 mentioned this pull request Dec 30, 2020
5 tasks
@mrmr1993
Copy link
Member Author

CI is very unhappy with this PR. Closing in favour of #7277.

@mrmr1993 mrmr1993 closed this Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants