Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove snark key download #15789

Open
wants to merge 3 commits into
base: compatible
Choose a base branch
from

Conversation

mrmr1993
Copy link
Member

@mrmr1993 mrmr1993 commented Jul 2, 2024

We no longer store snark keys in S3, so this codepath is entirely unused. This PR removes the compile-time configuration option and the logic for downloading those keys.

@mrmr1993 mrmr1993 requested review from a team as code owners July 2, 2024 18:50
@mrmr1993
Copy link
Member Author

mrmr1993 commented Jul 2, 2024

!ci-build-me

@martyall
Copy link
Member

#15837 subsumes a lot of the changes to mlh files, but doesn't eliminate the feature. perhaps we could look at merging that and then removal ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants