Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Ledger Bucket with Create Only Perms + Moving the CI to devnet from berkeley #15731

Draft
wants to merge 92 commits into
base: compatible
Choose a base branch
from

Conversation

svv232
Copy link
Member

@svv232 svv232 commented Jun 10, 2024

We have allocated a new read only bucket for the ledger tarball in CI. This is to prevent the file from accidentally being overwritten by another process pushing to the bucket. The approach here was to simply find and replace the old link. I still have to sanity check if this is correct and would appreciate feedback from @dkijania.

@svv232 svv232 requested review from a team as code owners June 10, 2024 19:09
@svv232
Copy link
Member Author

svv232 commented Jun 10, 2024

!ci-build-me

@svv232 svv232 marked this pull request as draft June 10, 2024 21:01
@svv232
Copy link
Member Author

svv232 commented Jun 11, 2024

!ci-build-me

@svv232
Copy link
Member Author

svv232 commented Jun 11, 2024

!ci-build-me

@SanabriaRusso
Copy link
Collaborator

Aware there is a auth issue in CI for reading the bucket. Keeping an eye on progress 👀

@svv232
Copy link
Member Author

svv232 commented Jun 12, 2024

!ci-build-me

@svv232
Copy link
Member Author

svv232 commented Jun 12, 2024

!ci-build-me

@svv232
Copy link
Member Author

svv232 commented Jun 12, 2024

!ci-build-me

@svv232
Copy link
Member Author

svv232 commented Jun 12, 2024

!ci-build-me

@svv232
Copy link
Member Author

svv232 commented Jun 13, 2024

!ci-build-me

@svv232
Copy link
Member Author

svv232 commented Jun 13, 2024

!ci-build-me

@svv232
Copy link
Member Author

svv232 commented Jun 13, 2024

!ci-build-me

@svv232
Copy link
Member Author

svv232 commented Jun 13, 2024

!ci-build-me

@svv232
Copy link
Member Author

svv232 commented Jul 3, 2024

!ci-build-me

1 similar comment
@svv232
Copy link
Member Author

svv232 commented Jul 4, 2024

!ci-build-me

@svv232
Copy link
Member Author

svv232 commented Jul 4, 2024

!ci-build-me

@svv232
Copy link
Member Author

svv232 commented Jul 4, 2024

!ci-build-me

@svv232 svv232 changed the title replacing writable bucket with ro bucket in ci for ledger tarball New Ledger Bucket with Create Only Perms + Moving the CI to devnet from berkeley Jul 4, 2024
@georgeee georgeee changed the base branch from develop to compatible July 12, 2024 09:38
Copy link
Member

@georgeee georgeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please split this PR. Separately: create-only permissions and CI changes.

@georgeee
Copy link
Member

Some more suggestions/questions:

  • Network berkeley is removed from dhall configuration. I'm afraid it may have unexpected consequences for build flow, I'd suggest it to be a separate PR if the change is needed
  • Let's squash commits, so that this PR becomes 3-4 separate PRs with 1-4 well-described commits each

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants