Support for account deletion in ledgers #15730
Draft
+1,385
−344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks interesting so far! i am curious to see how the ledger will eventually be affected |
mrmr1993
reviewed
Jun 10, 2024
rbonichon
force-pushed
the
rb/account-deletion
branch
from
5c533a7
to
0339150
Compare
rbonichon
force-pushed
the
rb/account-deletion
branch
2 times, most recently
from
2c6895a
to
41d133e
Compare
rbonichon
force-pushed
the
rb/account-deletion
branch
from
d64215e
to
cd08f51
Compare
rbonichon
changed the title
rbonichon
force-pushed
the
rb/account-deletion
branch
from
d6477ce
to
86b5292
Compare
mrmr1993
reviewed
Jul 17, 2024
rbonichon
force-pushed
the
rb/account-deletion
branch
5 times, most recently
from
8a3abce
to
55f09fc
Compare
…ster_nightly_fix_to_develop
…tly_fix_to_develop Port Fix nightly on master to develop
…remove_berkeley_migration_apps_dev
This reverts commit 25dccfe1bf616e3e2fc70ed5c0f6b3ebd2cbbdc2, reversing changes made to a801a21.
…_master [CI][Nightly][Master] Making master nightly green again
…migration_apps_dev Port remove migration apps from master to develop
…migration_apps Remove migration apps and jobs from master
It appears we do not need to cache deleted accounts. There is a simpler solution that checks when calling the parent's location of account whether the returned value, if any, was actually freed beforehand.
parent -> child signaling needs to check for account equality
This models the behavior of parent_set_notify, that is, the changes are propagated when the ledgers agree on the account that is touched.
rbonichon
force-pushed
the
rb/account-deletion
branch
from
71881bd
to
b9792e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is draft PR, intended to show and track implementation progress.
The commits at the moment are mostly informative and will be rebased to get a cleaner history, once it is ready.
This fixes #15742