Skip to content

Commit

Permalink
Add some images to README
Browse files Browse the repository at this point in the history
  • Loading branch information
Dika Adhitama committed Oct 1, 2019
1 parent 500b7f1 commit 15f29db
Show file tree
Hide file tree
Showing 8 changed files with 9 additions and 1 deletion.
3 changes: 2 additions & 1 deletion CONTRIBUTORS.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,5 @@ Tambahkan nama dan link profil anda dibawah ini dengan cara:
# Para Kontributor

- [Denny Pradipta](https://www.github.com/dennypradipta)
- [Muhammad Mugni Hadi](https://github.com/mugnimaestra)
- [Muhammad Mugni Hadi](https://github.com/mugnimaestra)
- [Dika Adhitama](https://github.com/kucinghitam13)
7 changes: 7 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ Kontribusi yang anda lakukan sangat simpel, yaitu menambahkan nama anda dan link
**PR** dapat dilakukan dengan mengikuti langkah-langkah sebagai berikut:

- ***Fork*** *repository* ini (klik tombol di pojok kanan atas)
![fork](assets/fork.jpg)
- Setelah proses *fork* selesai, lakukan:
```
# Kode ini dilakukan di terminal Linux atau OSX
Expand All @@ -36,19 +37,25 @@ git clone <link repository yang sudah difork>
# Pindah ke directory belajar-pull-request
cd belajar-pull-request
```
![clone](assets/clone.png)
- Ubah file sesuai dengan keperluan anda
- Commit file yang tadi sudah diubah dengan cara
```
git commit . -m 'isi pesan commit'
```
![commit](assets/commit.png)
[Writing good commit messages](https://github.com/erlang/otp/wiki/writing-good-commit-messages)
- *Push* ke *repository* anda dengan cara:
```
# Push ke repository anda
git push origin master
```
![push](assets/push.png)
- Buka halaman *repository* ini, lalu tekan tombol ***Create Pull Request***
![createpr](assets/createpr.jpg)
- Cek kembali apakah ada *conflict* antara apa yang anda *push* dan yang ada di *repository* sekarang. Apabila ada, anda harus kembali ke terminal dan melakukan ```git pull origin master``` di terminal anda, lalu ***push*** kembali.
- Jika tidak ada *conflict*, tekan tombol ***Create Pull Request***
![createpr2](assets/createpr2.jpg)
- Setelah anda melakukan **PR**, **PR** yang anda lakukan akan direview oleh pemilik *repository* yaitu saya. Apabila sesuai, akan saya *merge*.
- **Selesai!**

Expand Down
Binary file added assets/clone.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added assets/commit.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added assets/createpr.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added assets/createpr2.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added assets/fork.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added assets/push.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 15f29db

Please sign in to comment.