Refactoring and reorganizing code. #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reworked some of the file name lists Reworked CMP_Decode to decode at extraction time Reworked CMP_Decode to fix heap corruption + buffer overrun General Cleanup
wagrenier
requested changes
Oct 29, 2023
…er quirks. (I have tested it extensively, and cross referenced it with Zero 3) Added utility namespace for game functions and custom functions Removed some empty files that were no longer in use. Addressed some of the comments and requests.
…er quirks. (I have tested it extensively, and cross referenced it with Zero 3) Added a utility namespace for required game functions and custom functions. Removed some empty files that were no longer in use. Addressed some formatting issues.
wagrenier
requested changes
Oct 31, 2023
…e and game code. Reworked game address tables because one common struct doesn't work across all 3 games. Added functions from Zero2 for dealing with file checks (Exists, Compressed, Sector, etc). Cleaned up some PR requests.
…e and game code. Reworked game address tables because one common struct doesn't work across all 3 games. Added functions from Zero2 for dealing with file checks (Exists, Compressed, Sector, etc). Cleaned up some PR requests.
Smart pointers
wagrenier
reviewed
Nov 3, 2023
wagrenier
approved these changes
Nov 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added abstract readers to make it easier to deal with each game separately (Currently only supports Zero 2)
Cleaned up file directory list and file name list for Zero 2.
Exports now respect whole file size and trims instead of reading chunks of PS2_SECTOR_SIZE (2048). This was causing buffer overruns and some garbage in file buffers.
CMP_Decode now decodes the stream as files are read and saved, rather than reopening the file later.
CMP_Decode now decodes with 4 byte pointers instead of 8, which was causing heap corruption in some cases.