Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow configuring errors to cache instead of caching all #28

Merged
merged 6 commits into from
Sep 26, 2023

Conversation

MikaAK
Copy link
Owner

@MikaAK MikaAK commented Aug 31, 2023

No description provided.

@MikaAK MikaAK changed the title feat: add tests for caching on error cases and increase test coverage feat: allow configuring errors to cache instead of caching all Sep 6, 2023
@MikaAK MikaAK force-pushed the feat/no-error-caching branch 2 times, most recently from 4b44628 to 542e260 Compare September 14, 2023 02:01
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage: 98.33% and project coverage change: +6.62% 🎉

Comparison is base (90f1f38) 88.07% compared to head (149e3b5) 94.70%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
+ Coverage   88.07%   94.70%   +6.62%     
==========================================
  Files          11        9       -2     
  Lines         151      170      +19     
==========================================
+ Hits          133      161      +28     
+ Misses         18        9       -9     
Files Changed Coverage Δ
lib/request_cache/plug.ex 95.60% <96.55%> (+1.00%) ⬆️
lib/request_cache.ex 75.00% <100.00%> (ø)
lib/request_cache/config.ex 87.50% <100.00%> (+1.78%) ⬆️
lib/request_cache/middleware.ex 96.00% <100.00%> (+11.38%) ⬆️
lib/request_cache/util.ex 93.33% <100.00%> (+43.33%) ⬆️
test/support/utils.ex 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MikaAK MikaAK force-pushed the feat/no-error-caching branch 3 times, most recently from 39fa31c to 53e671b Compare September 14, 2023 07:42
…ql middleware (#29)

* feat: add ability to whitelist specific query names when adding graphql middleware

* chore: add docs for whitelisting
@MikaAK MikaAK merged commit d6a0e10 into main Sep 26, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant