4801 invalid utf8 in prompt #4802
Open
+24
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
needs triage
…in the prompt Properly resynchronize immediately after some invalid UTF-8 segment, instead of swallowing some subsequent letters or possibly even walking beyond the end of the string. Signed-off-by: Egmont Koblinger <[email protected]>
egmontkob
force-pushed
the
4801_invalid_utf8_in_prompt
branch
from
6ae71e3 to
1b3bb9b
Compare
2 tasks
zyv
added
area: core
2 tasks
ossilator
reviewed
Oct 20, 2025
There was a problem hiding this comment.
i don't know the entire context, so i can't possibly approve this, but from what i do see it looks sane.
same applies to the followup patch, which i'd squash here.
the autotest doesn't cover combining ctrl codes with botched utf8, which seems like a relevant omission. as you noted, the exact semantics probably aren't all too important, but the boundary conditions should be exercised for robustness.
note that afaict, you're fixing a security hole here: root may be browsing a user's folders, which are prepared to exploit the heap overflow. say hello to a CVE process ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Don't assume that the prompt is valid UTF-8
Resolves: #4801
Checklist
👉 Our coding style can be found here: https://midnight-commander.org/coding-style/ 👈
git commit --amend -smake indent && make check)