Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding winui3 sample, separate SLN due to project structure needs #142

Closed
wants to merge 15 commits into from

Conversation

DavidShoe
Copy link
Contributor

No description provided.

2 Update the package project wapproj file for the version your using
<pre> < Content Include="FixedRuntime\95.0.1020.53\\**\*.*" > </pre>
3 Uncomment the code in app.xaml.cs to enable the runtime override
<pre>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this can be tagged in this Suggestion UI. Recomm:

Above start of code block, put 3 backticks (indented 3 or 4 spaces, to match "U" of "Uncomment"). To right of triple backticks, add a lang abbrev such as csharp (no delim space).

Below end of code block, put 3 backticks (indented 3 or 4 spaces consistent w/ the containing list in this Markdown file).

Indent lines of code 3 or 4 spaces, consistent w/ the containing list.

DavidShoe and others added 14 commits July 21, 2022 14:38
This sample shows off using a WebView2 control in a WinUI 3 Windows SDK Packaged application.

This sample also shows how to optionally update the application to ship packaged together with a fixed version of the WebView2 Runtime, instead of using the version of the WebView2 Runtime that's installed on the user's computer.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add info like top of other samples' readmes:
This project was created using Visual Studio 2022[|2019]. It uses [programming language list] in the WebView2 context.

motivation for PR comment: I just opened this project in VS2019 but I think I should reopen it in VS2022, need a hint here.

Copy link
Collaborator

@peiche-jessica peiche-jessica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please work with @mikehoffms on readme.md. Other than that the project LGTM.

@@ -0,0 +1,55 @@
# WebView2_WinUI3_Sample
Copy link
Contributor

@mikehoffms mikehoffms Jul 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# WebView2_WinUI3_Sample
---
description: Demonstrates how to host the WebView2 control in a WinUI 3 (Windows App SDK) app.
extendedZipContent:
-
path: SharedContent
target: SharedContent
-
path: LICENSE
target: LICENSE
languages:
- xaml
- csharp
page_type: sample
products:
- microsoft-edge
urlFragment: WebView2_WinUI3_Sample
---
# WebView2_WinUI3_Sample

Copy link
Contributor

@mikehoffms mikehoffms Jul 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DavidShoe - Is the list of coding "languages: " above correct? Messaged you a link to list of valid values.

@peiche-jessica
Copy link
Collaborator

Closing this as the WinUI3 sample is added with #222

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants