Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kms-create-host.md #7993

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Conversation

JayMSFT2468
Copy link
Contributor

Recommended changes to the Prerequisites section.

Recommended changes to the Prerequisites section.
Copy link
Contributor

@JayMSFT2468 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 7f640de:

⚠️ Validation status: warnings

File Status Preview URL Details
WindowsServerDocs/get-started/kms-create-host.md ⚠️Warning Details

WindowsServerDocs/get-started/kms-create-host.md

  • Line 31, Column 118: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/windows-server/get-started/kms-activation-planning?tabs=server25' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 31, Column 118: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/windows-server/get-started/kms-activation-planning?tabs=server25' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@Court72
Copy link
Contributor

Court72 commented Nov 20, 2024

@robinharwood, @Xelu86

Can you review the proposed changes?

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Nov 20, 2024
@warren-msft
Copy link
Contributor

@robinharwood Can you take a look at this PR?

Copy link
Contributor

Learn Build status updates of commit 8ae0351:

✅ Validation status: passed

File Status Preview URL Details
WindowsServerDocs/get-started/kms-create-host.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@robinharwood
Copy link
Collaborator

Looks good, signing off and merging #sign-off

@robinharwood robinharwood merged commit d5c3a61 into MicrosoftDocs:main Dec 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants