Skip to content

Conversation

lwojtanowski
Copy link

Reason:

Explaining the manifest modification process. Expanding the instructions will help avoid the AADSTS50146 error.

@Copilot Copilot AI review requested due to automatic review settings September 12, 2025 19:35
Copy link
Contributor

@lwojtanowski : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the documentation for configuring claims mapping policies to provide clearer instructions and prevent the AADSTS50146 error. The changes expand the step-by-step instructions for modifying the application manifest.

  • Clarifies that the acceptMappedClaims attribute should be located under the api object
  • Adds an important note about setting properties in the root object for legacy AAD Graph App Manifest
  • Updates step numbering to be more consistent
Comments suppressed due to low confidence (1)

docs/identity-platform/custom-extension-tokenissuancestart-configuration.md:229

  • The JSON example shows acceptMappedClaims and requestedAccessTokenVersion at the root level, but the instructions specify that acceptMappedClaims should be under the api object. The example should be updated to reflect the correct structure or include both locations to match the instructions.
{
	"id": "22222222-0000-0000-0000-000000000000",
	"acceptMappedClaims": true,
	"requestedAccessTokenVersion": 2,  
    ...
}

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

Learn Build status updates of commit 7154513:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/identity-platform/custom-extension-tokenissuancestart-configuration.md ⚠️Warning Details

docs/identity-platform/custom-extension-tokenissuancestart-configuration.md

  • Line 233, Column 202: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/entra/identity-platform/reference-microsoft-graph-app-manifest' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 233, Column 202: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/entra/identity-platform/reference-microsoft-graph-app-manifest' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

@Court72
Copy link
Contributor

Court72 commented Sep 12, 2025

@cilwerner

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants