Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New article "Debug DOM memory leaks ("Detached elements" profiling type)" #3282

Merged
merged 70 commits into from
Oct 23, 2024

Conversation

mikehoffms
Copy link
Contributor

@mikehoffms mikehoffms commented Sep 24, 2024

Overview of changes:

  • Detached Elements tool
    • Debug DOM memory leaks by using the Detached Elements tool
      • Before/Live
      • Streamlined list of 12 UI steps, instead of four separate verbose sections, & clarified.
        • Used as template for the other articles.
  • Memory tool
    • Fix memory problems
      • Before/Live
      • Converted from details to overview/nav tables: Use case | Tool | Article.
      • Identified 3 tools for detached elements; related & clarified them.
      • Moved content to dedicated tool/profiling type articles.
    • Monitor memory use in realtime (Microsoft Edge Browser Task Manager)
      • Live
      • New article.
      • Clarified, showed resulting "JavaScript memory" column.
    • Record heap snapshots using the Memory tool ("Heap snapshot" profiling type)
      • Before/Live
      • Updated, expanded.
      • Added section:
        Find DOM tree memory leaks ("Heap snapshot" profiling type > Detached)
      • Title added which profiling type.
      • Updated, clarified UI steps leveraging demos.
      • ⁠Cross-linked; integrated/coordinated.
    • Use Allocation instrumentation on timeline ("Allocations on timeline" profiling type)
      • Before/Live
      • Updated option button.
      • Title added which profiling type.
      • Updated, clarified UI steps leveraging demos.
      • ⁠Cross-linked; integrated/coordinated.
    • Speed up JavaScript runtime ("Allocation sampling" profiling type)
      • Before/Live
      • Clarified "Profile view mode" dropdown list & UI: Chart, Heavy (Bottom Up), Tree (Top Down).
      • Clarified & updated icons/buttons: Focus selected function, Exclude selected function, Restore all functions.
      • Title added which profiling type.
      • Updated, clarified UI steps leveraging demos.
      • ⁠Cross-linked; integrated/coordinated.
    • Debug DOM memory leaks ("Detached elements" profiling type)
  • Performance tool
    • Performance features reference
      • Before/Live
      • New section "Visualize memory leaks (Performance tool: Memory checkbox)".
      • Updated, clarified UI steps leveraging demos.

AB#53793112
AB#54106512

@mikehoffms mikehoffms added in-progress cat: devtools DevTools-related content. labels Sep 24, 2024
@mikehoffms mikehoffms changed the title Revise Detached Elements article Revise “Debug DOM memory leaks with the Detached Elements profiling type” Oct 10, 2024
@mikehoffms mikehoffms changed the title Revise “Debug DOM memory leaks with the Detached Elements profiling type” Update “Debug DOM memory leaks with the Detached Elements profiling type” Oct 10, 2024
@mikehoffms mikehoffms changed the title Add "Detached elements" in "Memory tool", clarify "Detached Elements tool" New article for Memory tool's "Detached elements" profiling type Oct 21, 2024
@mikehoffms mikehoffms changed the title New article for Memory tool's "Detached elements" profiling type New article "Debug DOM memory leaks ("Detached elements" profiling type)" Oct 21, 2024
Copy link
Contributor Author

@mikehoffms mikehoffms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Learn Build status updates of commit 0efe702:

✅ Validation status: passed

File Status Preview URL Details
microsoft-edge/dev-videos/index.md ✅Succeeded View
microsoft-edge/devtools-guide-chromium/about-tools.md ✅Succeeded View
microsoft-edge/devtools-guide-chromium/console/utilities.md ✅Succeeded View
microsoft-edge/devtools-guide-chromium/evaluate-performance/reference-images/performance-memory.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/evaluate-performance/reference.md ✅Succeeded View
microsoft-edge/devtools-guide-chromium/experimental-features/index.md ✅Succeeded View
microsoft-edge/devtools-guide-chromium/experimental-features/share-traces-images/importing-memory-trace.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/experimental-features/share-traces.md ✅Succeeded View
microsoft-edge/devtools-guide-chromium/landing/index.yml ✅Succeeded View
microsoft-edge/devtools-guide-chromium/memory-problems/allocation-profiler-images/allocation-timeline-snapshot-all.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/memory-problems/allocation-profiler-images/allocation-timeline-snapshot-focused-constructor-expanded.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/memory-problems/allocation-profiler-images/allocation-timeline-snapshot-focused.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/memory-problems/allocation-profiler-images/allocation-timelines-profile.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/memory-problems/allocation-profiler-images/instrumentation-on-timeline-selected.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/devtools-guide-chromium/memory-problems/allocation-profiler-images/memory-tool-allocations-on-timeline-option-button.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/memory-problems/allocation-profiler-images/memory-tool-icon.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/memory-problems/allocation-profiler-images/profiles-icon.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/memory-problems/allocation-profiler-images/stop-recording-icon.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/memory-problems/allocation-profiler.md ✅Succeeded View
microsoft-edge/devtools-guide-chromium/memory-problems/dom-leaks-images/after-click-detach-elements.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/memory-problems/dom-leaks-images/analyze-detached-elements.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/memory-problems/dom-leaks-images/demo-app.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/memory-problems/dom-leaks-images/detached-elements-tool-icon.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/memory-problems/dom-leaks-images/detached-elements-tool.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/memory-problems/dom-leaks-images/get-detached-elements.png ✅Succeeded View

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.

For any questions, please:

@captainbrosset captainbrosset merged commit d3618cf into main Oct 23, 2024
2 checks passed
@captainbrosset captainbrosset deleted the user/mikehoffms/depr-detached-elem branch October 23, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat: devtools DevTools-related content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants