-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update extension tutorial to use Manifest V3 #2014
Conversation
Thank you so much for the PR @eclipse439! We'll give this a review soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Iam fine by these changes, but am not fully sure if these cover everything. Will be nice to get a pass from Utkarsh Patankar as well.
Sounds great to me. @ashishnirvana1 are you able to at-mention them here? I don't know what their username is on GitHub. |
@captainbrosset I am unable to add Utkarsh here as a Reviewer. Will get this reviewed offline and update this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still in review by @ashishnirvana1 to confirm that the tutorial is complete. We also need to implement tabs for MV2 and MV3.
@mikehoffms - can you update the doc with the tabs please?
Docs Build status updates of commit fdc6c28: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
@Reezaali
|
For now, I will leave my review as blocking the merge until we hear back from @ashishnirvana1 to confirm that no additional changes are needed to the tutorial. Thanks! |
Docs Build status updates of commit b7fe1e3: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
microsoft-edge/extensions-chromium/getting-started/part1-simple-extension.md
Show resolved
Hide resolved
microsoft-edge/extensions-chromium/getting-started/part2-content-scripts.md
Show resolved
Hide resolved
Utkarsh has suggested the below changes to the documentation:
Old version: Finally, ensure you register the pop-up in
Since it mentions that the source code has been updated from Manifest V2 to Manifest V3, we should actually update the source code first before we update this documentation. Could you please review & approve GitHub PR #34 - Update Edge Extension Tutorials to use Manifest V3 by eclipse439 · MicrosoftEdge/MicrosoftEdge-Extensions-Demos? |
@mikehoffms - I merged PR34 above as mentioned by @sonakshimore. Thanks. |
microsoft-edge/extensions-chromium/getting-started/part1-simple-extension.md
Outdated
Show resolved
Hide resolved
Docs Build status updates of commit ed86ec3: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
Docs Build status updates of commit dd549aa: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
|
||
--- | ||
|
||
4. Make your `stars.jpeg` available from any browser tab | ||
|
||
You're probably wondering why, when you pass the `images/stars.jpeg` must you use the `chrome.extension.getURL` chrome Extension API instead of just passing in the relative URL without the extra prefix like in the previous section. By the way, that extra prefix, returned by `getUrl` with the image attached looks something like the following. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This V2-specific word|sentence|paragraph needs techreview in future PR. chrome.extension.getURL is V2-specific. @ashishnirvana1 @eclipse439
rendered:
https://docs.microsoft.com/en-us/microsoft-edge/extensions-chromium/getting-started/part2-content-scripts?tabs=v2
find chrome.extension.getURL then click tabs
As requested by multiple users, this PR updates docs to change manifest version to v3, as well as replace any deprecated functions.
I've also added a PR to update the source code linked in the docs here: MicrosoftEdge/MicrosoftEdge-Extensions-Demos#34
Issues requesting update: #2012 #1878
Rendered pages for review:
https://review.docs.microsoft.com/en-us/microsoft-edge/extensions-chromium/getting-started/part1-simple-extension?branch=pr-en-us-2014
https://review.docs.microsoft.com/en-us/microsoft-edge/extensions-chromium/getting-started/part2-content-scripts?branch=pr-en-us-2014