Skip to content

Standardize requires standard version comments #5510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Rageking8
Copy link
Contributor

  • Replace "higher" with "later" as it's more precise and consistent with the ones in the standard library reference
  • Replace "or /std:c++latest" since we already have /std:c++23preview, and we don't want to list all applicable variants down
  • Remove comma for uniformity

Copy link
Contributor

Learn Build status updates of commit 1dbc6f1:

✅ Validation status: passed

File Status Preview URL Details
docs/c-language/static-assert-c.md ✅Succeeded
docs/c-runtime-library/reference/acos-acosf-acosl.md ✅Succeeded
docs/c-runtime-library/reference/acosh-acoshf-acoshl.md ✅Succeeded
docs/c-runtime-library/reference/asin-asinf-asinl.md ✅Succeeded
docs/c-runtime-library/reference/asinh-asinhf-asinhl.md ✅Succeeded
docs/c-runtime-library/reference/atan-atanf-atanl-atan2-atan2f-atan2l.md ✅Succeeded
docs/c-runtime-library/reference/atanh-atanhf-atanhl.md ✅Succeeded
docs/c-runtime-library/reference/carg-cargf-cargl.md ✅Succeeded
docs/c-runtime-library/reference/cbrt-cbrtf-cbrtl.md ✅Succeeded
docs/c-runtime-library/reference/ceil-ceilf-ceill.md ✅Succeeded
docs/c-runtime-library/reference/cimag-cimagf-cimagl.md ✅Succeeded
docs/c-runtime-library/reference/conj-conjf-conjl.md ✅Succeeded
docs/c-runtime-library/reference/copysign-copysignf-copysignl-copysign-copysignf-copysignl.md ✅Succeeded
docs/c-runtime-library/reference/cos-cosf-cosl.md ✅Succeeded
docs/c-runtime-library/reference/cosh-coshf-coshl.md ✅Succeeded
docs/c-runtime-library/reference/cproj-cprojf-cprojl.md ✅Succeeded
docs/c-runtime-library/reference/creal-crealf-creall.md ✅Succeeded
docs/c-runtime-library/reference/erf-erff-erfl-erfc-erfcf-erfcl.md ✅Succeeded
docs/c-runtime-library/reference/exp-expf.md ✅Succeeded
docs/c-runtime-library/reference/exp2-exp2f-exp2l.md ✅Succeeded
docs/c-runtime-library/reference/expm1-expm1f-expm1l.md ✅Succeeded
docs/c-runtime-library/reference/fabs-fabsf-fabsl.md ✅Succeeded
docs/c-runtime-library/reference/fdim-fdimf-fdiml.md ✅Succeeded
docs/c-runtime-library/reference/floor-floorf-floorl.md ✅Succeeded
docs/c-runtime-library/reference/fma-fmaf-fmal.md ✅Succeeded

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.

Copy link
Contributor

PRMerger Results

Issue Description
Changed Files This PR contains more than 10 changed files.

@v-dirichards
Copy link
Contributor

@TylerMSFT

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged Tracking label for the PR review team label Jul 8, 2025
Copy link
Collaborator

@TylerMSFT TylerMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sooner or later we'll get this all tidied up ;-)

@TylerMSFT
Copy link
Collaborator

#sign-off

@v-dirichards v-dirichards merged commit 00751ab into MicrosoftDocs:main Jul 9, 2025
2 checks passed
@Rageking8 Rageking8 deleted the standardize-requires-standard-version-comments branch July 9, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aq-pr-triaged Tracking label for the PR review team needs-human-review ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants