Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy up superfluous semicolons #171

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Tidy up superfluous semicolons #171

wants to merge 1 commit into from

Conversation

Rageking8
Copy link

Remove a couple of extra semicolons.

@prmerger-automator PRMerger Automator
Copy link
Contributor

@Rageking8 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@learn-build-service-prod Learn Build Service (PROD)
Copy link
Contributor

Learn Build status updates of commit 82439f8:

✅ Validation status: passed

File Status Preview URL Details
articles/ai-services/anomaly-detector/includes/quickstarts/anomaly-detector-client-library-java-multivariate.md ✅Succeeded
articles/ai-services/document-intelligence/how-to-guides/includes/v4-0/java-sdk.md ✅Succeeded
articles/ai-services/openai/includes/java.md ✅Succeeded
articles/machine-learning/v1/how-to-deploy-pipelines.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Rageking8
Rageking8 commented Jan 14, 2025
View reviewed changes
articles/machine-learning/v1/how-to-deploy-pipelines.md
@@ -177,7 +177,7 @@ Gson gson = new Gson();

HttpRequest tokenAuthenticationRequest = tokenAuthenticationRequest(tenantId, clientId, clientSecret, resourceManagerUrl);
Optional<String> authBody = getRequestBody(client, tokenAuthenticationRequest);
Optional<String> authKey = authBody.flatMap(body -> Optional.of(gson.fromJson(body, AuthenticationBody.class).access_token);;
Optional<String> authKey = authBody.flatMap(body -> Optional.of(gson.fromJson(body, AuthenticationBody.class).access_token));
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is missing a close parenthesis, hence the change.

@ttorble
Copy link
Contributor

ttorble commented Jan 14, 2025

@mrbullwinkle @laujan @lgayhardt

Can you review the proposed changes?

IMPORTANT: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged C+L Pull Request Review Team label label Jan 14, 2025
@github-actions GitHub Actions
Copy link

This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions.
Get Help
Docs Support Teams Channel
Resolve Merge Conflict

@github-actions github-actions bot added the inactive This PR is inactive for more than 14 days label Jan 28, 2025
@Rageking8
Copy link
Author

Hi @mrbullwinkle, @laujan, and @lgayhardt, could you help review this simple PR? Thanks a bunch!

@github-actions github-actions bot removed the inactive This PR is inactive for more than 14 days label Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrbullwinkle mrbullwinkle Awaiting requested review from mrbullwinkle

@laujan laujan Awaiting requested review from laujan

@lgayhardt lgayhardt Awaiting requested review from lgayhardt

Assignees

@lgayhardt lgayhardt

@mrbullwinkle mrbullwinkle

@laujan laujan

Labels
aq-pr-triaged C+L Pull Request Review Team label azure-machine-learning/svc Change sent to author do-not-merge mlops/subsvc qualifies-for-auto-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Rageking8 @ttorble @lgayhardt @mrbullwinkle @laujan