Repository navigation
Watsonbw qt - #40
Watsonbw qt#40
Conversation
…pages in favor of new one, implementation isn't CLOSE to being done
trevorswan11
left a comment
trevorswan11
left a comment
There was a problem hiding this comment.
This is looking very good, just a few polishing areas that would be good to capitalize on now so that they don't compound into something more later. Great work!
…building and compilation, linux you are out of luck
… working. Not a huge fan of the current design but I should be able to change it by tweaking the style
…he ImGui app feature wise. Desperately need to make the standard theme style pages
trevorswan11
left a comment
trevorswan11
left a comment
There was a problem hiding this comment.
Looking so great, It's really coming together. Just some small nits and performance minded improvements that can be made. Keep up the good work!
|
Do you think it's in scope of this PR to get the CI workflows to a point where they don't crash immediately. It's ok if not. |
|
Amazing job getting CI up and running again! |
|
praise: Great job with this! Happy to see all workflows passing. I'll review this when I get home later tonight and hopefully this can get pushed over the finish line by tmr night! |
trevorswan11
left a comment
trevorswan11
left a comment
There was a problem hiding this comment.
This is so close to getting merged. Once these comments get resolved I think this guy is ready!
| SECTION("Handling missing keys") { | ||
| const auto& series_missing = data.get_series("UNKNOWN_KEY"); | ||
| CHECK(series_missing.empty()); | ||
| CHECK(series_missing.get()->empty()); |
There was a problem hiding this comment.
issue: Replace this with CHECK_FALSE(series_missing); since optional is used for empty states instead of the pre-existing static vector
…ormat but whatever the marginal speed increase is worth
trevorswan11
left a comment
trevorswan11
left a comment
There was a problem hiding this comment.
Looks great! Last thing is getting that failing test fixed. I left the solution to the problem in the comments. Great work with this! Really happy with how this turned out!
2 participants
Qt logic has been updated, fixing errors such as backend_bridge not using a uniqueptr to backend, various enum updates using stdx, and others. New features include plot_page.cpp being fully functional using QCustomPlot. Pretty happy with the progress, although a system wide formatting and color standard needs to be implemented sooner rather than later. Finally, I'd like to look into better ways of designing the buttons, menus, etc as I don't understand where people make good looking things. Furthermore on plot.cpp specifically, with the implementation of qt we have lost some nice comforts with ImPlot, goal would be to eventually update plot.cpp with the helper logic previously embedded in ImPlot: zeroing, zoom to plot, etc.
