Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Remove excluded files before the batch upload #738

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Conversation

witwash
Copy link
Contributor

@witwash witwash commented Jan 29, 2025

Summary

  • could not make --pattern skip those files, instead it had skipped all the files
  • removed files that had to be skipped before the batch-upload

Testing steps

Info about test cases. If you think the issue is not testable, describe why.

Follow-up issues

Is there some action/cleanup needed after this PR is merged or deployed (e.g. consolidate some part outside the scope of this PR, etc)? Create issues for it with deadline and note them here and in the PR comments.

Check during review

  • Verify against Jira issue.
  • Is the PR over 300 additions? Consider rejecting it with advice to split it. Is it over 500 additions? It should definitely be rejected.
  • Unused code removed.
  • Build passing.
  • Is it a bug fix? Check that it is covered by a proper test (unit or integration).

@witwash witwash requested a review from a team as a code owner January 29, 2025 14:57
@witwash witwash enabled auto-merge (squash) January 29, 2025 15:02
@witwash witwash changed the title ci: Update exclude pattern ci: Remove excluded files before the batch upload Jan 29, 2025
Copy link
Contributor

@chaeMil chaeMil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yolo

@witwash witwash merged commit dd6eff8 into main Jan 29, 2025
9 checks passed
@witwash witwash deleted the fix-upload-pattern branch January 29, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants