Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Change widgetbook base-href #733

Merged
merged 4 commits into from
Jan 28, 2025
Merged

ci: Change widgetbook base-href #733

merged 4 commits into from
Jan 28, 2025

Conversation

witwash
Copy link
Contributor

@witwash witwash commented Jan 28, 2025

Summary

Another attempt to fix base-href. The build is deployed to the release folder so the base-href should be the same as the path on the blob. Per documentation.

  • changed base-href to /release/

Testing steps

Info about test cases. If you think the issue is not testable, describe why.

Follow-up issues

Is there some action/cleanup needed after this PR is merged or deployed (e.g. consolidate some part outside the scope of this PR, etc)? Create issues for it with deadline and note them here and in the PR comments.

Check during review

  • Verify against Jira issue.
  • Is the PR over 300 additions? Consider rejecting it with advice to split it. Is it over 500 additions? It should definitely be rejected.
  • Unused code removed.
  • Build passing.
  • Is it a bug fix? Check that it is covered by a proper test (unit or integration).

@witwash witwash requested a review from a team as a code owner January 28, 2025 11:57
@witwash witwash changed the title Widgetbook fix index ci: Change widgetbook base-href Jan 28, 2025
@witwash witwash enabled auto-merge (squash) January 28, 2025 11:58
@witwash witwash disabled auto-merge January 28, 2025 12:04
@witwash
Copy link
Contributor Author

witwash commented Jan 28, 2025

@chaeMil 🙏

@witwash witwash enabled auto-merge (squash) January 28, 2025 12:09
@witwash witwash merged commit f20d7d6 into main Jan 28, 2025
7 checks passed
@witwash witwash deleted the widgetbook-fix-index branch January 28, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants