Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: [DX-2273] Add Azure upload workflow #709

Merged
merged 13 commits into from
Dec 3, 2024
Merged

ci: [DX-2273] Add Azure upload workflow #709

merged 13 commits into from
Dec 3, 2024

Conversation

witwash
Copy link
Contributor

@witwash witwash commented Nov 27, 2024

Summary

We're moving optimus_widgetbook to widgetbook.mews.design domain. It's the first step to automate deploy, like it is now, but instead of Firebase we'll be using Azure.

  • added Azure upload workflow

Testing steps

None

Follow-up issues

Setup the hosting of the deployed app.

Check during review

  • Verify against Jira issue.
  • Is the PR over 300 additions? Consider rejecting it with advice to split it. Is it over 500 additions? It should definitely be rejected.
  • Unused code removed.
  • Build passing.
  • Is it a bug fix? Check that it is covered by a proper test (unit or integration).

@witwash
Copy link
Contributor Author

witwash commented Nov 27, 2024

@ben-wilson-mews, lets look at it together. I'm a bit lost with all those ids. Hope you can help me 🙏 I'm building the web app in the step before the upload. The whole web app is locatad in the build/web folder.

@ben-wilson-mews
Copy link

@ben-wilson-mews, lets look at it together. I'm a bit lost with all those ids. Hope you can help me 🙏 I'm building the web app in the step before the upload. The whole web app is locatad in the build/web folder.

While testing I'd recommend changing to just a push trigger.

Happy to help

@witwash witwash marked this pull request as ready for review November 29, 2024 17:06
@witwash witwash requested a review from a team as a code owner November 29, 2024 17:06
@witwash witwash merged commit bf3d190 into master Dec 3, 2024
7 checks passed
@witwash witwash deleted the DX-2273 branch December 3, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants