Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: [DX-3397] Upgrade to DCM 1.24.2 #703

Merged
merged 2 commits into from
Nov 18, 2024
Merged

feat!: [DX-3397] Upgrade to DCM 1.24.2 #703

merged 2 commits into from
Nov 18, 2024

Conversation

witwash
Copy link
Contributor

@witwash witwash commented Nov 18, 2024

Summary

Enabled rules:

Common:
Flutter:
Bloc:
Provider:

Added new rules from the flutter_lints:

Plus small refactoring: removing old rules (that were deleted from the flutter_lint) and rearranging rules in list, to match the list on dcm.dev.

Testing steps

None

Follow-up issues

None

Check during review

  • Verify against Jira issue.
  • Is the PR over 300 additions? Consider rejecting it with advice to split it. Is it over 500 additions? It should definitely be rejected.
  • Unused code removed.
  • Build passing.
  • Is it a bug fix? Check that it is covered by a proper test (unit or integration).

@witwash witwash requested review from a team as code owners November 18, 2024 09:31
@witwash witwash requested a review from ookami-kb November 18, 2024 10:15
@witwash witwash changed the title Dx 3397 feat!: [DX-3397] Upgrade to DCM 1.24.2 Nov 18, 2024
Copy link
Contributor

@ookami-kb ookami-kb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@witwash witwash merged commit 89c5a03 into master Nov 18, 2024
9 checks passed
@witwash witwash deleted the DX-3397 branch November 18, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants