Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Upgrade kiosk_mode #695

Merged
merged 4 commits into from
Oct 8, 2024
Merged

feat: Upgrade kiosk_mode #695

merged 4 commits into from
Oct 8, 2024

Conversation

alboiuvlad29
Copy link
Contributor

@alboiuvlad29 alboiuvlad29 commented Oct 7, 2024

Summary

Upgrades kiosk_mode:

  • To use the latest available AGP
  • To use the latest Kotlin version
  • Updates the example app to use imperative plugin apply
  • Replaces deprecated .buildDir with .layout.buildDirectory.

The changes are accurate, as they're taken from a freshly created app and plugin using flutter create. This should future-proof the package and allow the migrations to higher AGP versions in client flutter apps.

Fixes:

Testing steps

Ensure that kiosk_mode package and example app work as expected. I've tested the example app.

Follow-up issues

No.

Check during review

  • Verify against Jira issue.
  • Is the PR over 300 additions? Consider rejecting it with advice to split it. Is it over 500 additions? It should definitely be rejected.
  • Unused code removed.
  • Build passing.
  • Is it a bug fix? Check that it is covered by a proper test (unit or integration).

Copy link
Member

@Sevastyan Sevastyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's take it a step further and finally start using a version catalog.

https://docs.gradle.org/current/userguide/dependency_management_basics.html#version_catalog

@alboiuvlad29
Copy link
Contributor Author

alboiuvlad29 commented Oct 8, 2024

@Sevastyan Don't believe it's working properly with the flutter plugin. See this diff.

image

For some reason it's expecting the same libraries declarations in the example app which are declared in the plugin's catalogue, while it shouldn't. It also doesn't work with settings.gradle as the evaluation happens after this file.

Copy link
Member

@Sevastyan Sevastyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not this stop the PR from being merged.

However, keep in mind that version catalog is the standard we should migrate to sometime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants