feat!: [DX-2187] Upgrade to DCM 1.22.0

[witwash]

Summary

New rules:

• avoid-unnecessary-extends 🛠
• avoid-assignments-as-conditions
• avoid-type-casts ⚙️
• avoid-unused-assignment
• avoid-unnecessary-overrides 🛠
• avoid-duplicate-constant-values
• avoid-unnecessary-enum-arguments 🛠
• prefer-contains 🛠
• avoid-unnecessary-constructor 🛠
• avoid-implicitly-nullable-extension-types 🛠
• avoid-getter-prefix ⚙️
• avoid-unnecessary-enum-prefix 🛠
• avoid-non-final-exception-class-fields

New rules left disabled:

• avoid-assigning-to-static-field

Minor formatting and linter fixes

Testing steps

None

Follow-up issues

Release optimus_pedantic

Check during review

• Verify against Jira issue.
• Is the PR over 300 additions? Consider rejecting it with advice to split it. Is it over 500 additions? It should definitely be rejected.
• Unused code removed.
• Build passing.
• Is it a bug fix? Check that it is covered by a proper test (unit or integration).

[witwash]

@ookami-kb,
What about adding some rules from the pubspec section? For example, pinning dependencies is a good addition, WDYT?

[ookami-kb]

avoid-assigning-to-static-field

I don't see anything wrong with it, there are completely valid use cases like keeping track of the number of instances.

What about adding some rules from the pubspec section? For example, pinning dependencies is a good addition, WDYT?

Not sure, they don't look very useful to me.

[witwash]

@chaeMil, this one as well 👀