Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: [DX-2054] Update NavListTile design #665

Merged
merged 3 commits into from
Sep 5, 2024
Merged

feat!: [DX-2054] Update NavListTile design #665

merged 3 commits into from
Sep 5, 2024

Conversation

witwash
Copy link
Contributor

@witwash witwash commented Aug 28, 2024 •
edited
Loading

Summary

  • reworked the NavListTile as it was split into two versions GX and B2C
Preview
CleanShot.2024-08-28.at.12.38.37.mp4

Testing steps

  1. Open the Navigation List Tile story
  2. Test the component using exposed knobs

Follow-up issues

None

Check during review

  • Verify against Jira issue.
  • Is the PR over 300 additions? Consider rejecting it with advice to split it. Is it over 500 additions? It should definitely be rejected.
  • Unused code removed.
  • Build passing.
  • Is it a bug fix? Check that it is covered by a proper test (unit or integration).

@witwash witwash changed the title Dx 2054 feat!: [DX-2054] Update NavListTile design Aug 28, 2024
@witwash witwash marked this pull request as ready for review August 28, 2024 10:40
@witwash witwash requested a review from a team as a code owner August 28, 2024 10:40
@witwash
Copy link
Contributor Author

witwash commented Sep 5, 2024

@chaeMil 👀

@witwash witwash merged commit 26e5541 into master Sep 5, 2024
12 checks passed
@witwash witwash deleted the DX-2054 branch September 5, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaeMil chaeMil chaeMil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@witwash @chaeMil