Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [DX-2097] Expand Input touch zone #659

Merged
merged 1 commit into from
Aug 16, 2024
Merged

feat: [DX-2097] Expand Input touch zone #659

merged 1 commit into from
Aug 16, 2024

Conversation

witwash
Copy link
Contributor

@witwash witwash commented Aug 14, 2024

Summary

  • wrapped FieldWrapper with a GestureDetector to enlarge the touch zone to focus on input.

Testing steps

  1. Open any story with an InputField in it
  2. Test that the field is focused after you interact with any of its components, including label and helper message.

Follow-up issues

None.

Check during review

  • Verify against Jira issue.
  • Is the PR over 300 additions? Consider rejecting it with advice to split it. Is it over 500 additions? It should definitely be rejected.
  • Unused code removed.
  • Build passing.
  • Is it a bug fix? Check that it is covered by a proper test (unit or integration).

@witwash witwash marked this pull request as ready for review August 15, 2024 12:12
@witwash witwash requested a review from a team as a code owner August 15, 2024 12:12
@witwash witwash enabled auto-merge (squash) August 15, 2024 16:11
chaeMil
chaeMil approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@chaeMil chaeMil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@witwash witwash merged commit e1940fe into master Aug 16, 2024
7 checks passed
@witwash witwash deleted the DX-2097 branch August 16, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaeMil chaeMil chaeMil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@witwash @chaeMil