Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): publish packages #654

Merged
merged 1 commit into from
Aug 5, 2024
Merged

chore(release): publish packages #654

merged 1 commit into from
Aug 5, 2024

Conversation

witwash
Copy link
Contributor

@witwash witwash commented Aug 5, 2024

Summary

Describe anything that you feel other developers should know.

Testing steps

Info about test cases. If you think the issue is not testable, describe why.

Follow-up issues

Is there some action/cleanup needed after this PR is merged or deployed (e.g. consolidate some part outside the scope of this PR, etc)? Create issues for it with deadline and note them here and in the PR comments.

Check during review

  • Verify against Jira issue.
  • Is the PR over 300 additions? Consider rejecting it with advice to split it. Is it over 500 additions? It should definitely be rejected.
  • Unused code removed.
  • Build passing.
  • Is it a bug fix? Check that it is covered by a proper test (unit or integration).

@witwash witwash marked this pull request as ready for review August 5, 2024 12:55
@witwash witwash requested a review from a team as a code owner August 5, 2024 12:55
@witwash witwash marked this pull request as draft August 5, 2024 12:58
@witwash witwash marked this pull request as ready for review August 5, 2024 13:01
@witwash
Copy link
Contributor Author

witwash commented Aug 5, 2024

I forgot to update the tag. We're good to go now 👍

@witwash witwash merged commit 9d4f314 into master Aug 5, 2024
7 of 8 checks passed
@witwash witwash deleted the release-2024-08-05 branch August 5, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants