Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [DX-1642] Update Card component #647

Merged
merged 2 commits into from
Aug 13, 2024
Merged

feat: [DX-1642] Update Card component #647

merged 2 commits into from
Aug 13, 2024

Conversation

witwash
Copy link
Contributor

@witwash witwash commented Jul 31, 2024 •
edited
Loading

Summary

  • updated OptimusCard borders and colors
  • migrated to tokens
  • updated story

Testing steps

  1. Open Card story
  2. Test the component using exposed controls.

Follow-up issues

None

Check during review

  • Verify against Jira issue.
  • Is the PR over 300 additions? Consider rejecting it with advice to split it. Is it over 500 additions? It should definitely be rejected.
  • Unused code removed.
  • Build passing.
  • Is it a bug fix? Check that it is covered by a proper test (unit or integration).

@witwash witwash marked this pull request as ready for review August 7, 2024 14:19
@witwash witwash requested a review from a team as a code owner August 7, 2024 14:19
chaeMil
chaeMil approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@chaeMil chaeMil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flutter lgtm

@witwash witwash merged commit 0e41778 into master Aug 13, 2024
6 checks passed
@witwash witwash deleted the DX-1642 branch August 13, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaeMil chaeMil chaeMil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@witwash @chaeMil