Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [DX-1919] Add padding to multiline input #633

Merged
merged 1 commit into from
Jun 28, 2024
Merged

feat: [DX-1919] Add padding to multiline input #633

merged 1 commit into from
Jun 28, 2024

Conversation

witwash
Copy link
Contributor

@witwash witwash commented Jun 26, 2024 •
edited
Loading

Summary

  • added vertical padding to the input when the input is multi-lined
  • updated story
  • minor clean-up
Screenshots Before:

CleanShot 2024-06-26 at 11 45 43

After:

CleanShot 2024-06-26 at 11 41 14

Testing steps

  1. Open Input story
  2. Test input with various Minimal lines knob

Follow-up issues

None

Check during review

  • Verify against Jira issue.
  • Is the PR over 300 additions? Consider rejecting it with advice to split it. Is it over 500 additions? It should definitely be rejected.
  • Unused code removed.
  • Build passing.
  • Is it a bug fix? Check that it is covered by a proper test (unit or integration).

@witwash witwash marked this pull request as ready for review June 26, 2024 09:46
@witwash witwash requested a review from a team as a code owner June 26, 2024 09:46
@witwash witwash merged commit 1250c25 into master Jun 28, 2024
8 checks passed
@witwash witwash deleted the multiline-input branch June 28, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaeMil chaeMil chaeMil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@witwash @chaeMil