Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [DX-1801] Add TextArea component #632

Merged
merged 6 commits into from
Jul 26, 2024
Merged

feat: [DX-1801] Add TextArea component #632

merged 6 commits into from
Jul 26, 2024

Conversation

witwash
Copy link
Contributor

@witwash witwash commented Jun 24, 2024 •
edited
Loading

Summary

  • added OptimusTextArea
  • added story
Preview
CleanShot.2024-07-24.at.16.35.17.mp4

Testing steps

  1. Open Text Area story
  2. Test component using exposed knobs

Follow-up issues

  • add a possibility to define a vertical alignment of the input as it is now aligned only to the center.

Check during review

  • Verify against Jira issue.
  • Is the PR over 300 additions? Consider rejecting it with advice to split it. Is it over 500 additions? It should definitely be rejected.
  • Unused code removed.
  • Build passing.
  • Is it a bug fix? Check that it is covered by a proper test (unit or integration).

@witwash witwash marked this pull request as ready for review July 24, 2024 14:38
@witwash witwash requested a review from a team as a code owner July 24, 2024 14:38
@witwash witwash merged commit 7b46b55 into master Jul 26, 2024
7 checks passed
@witwash witwash deleted the DX-1801 branch July 26, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaeMil chaeMil chaeMil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@witwash @chaeMil