Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [DX-1395] Add ToggleButton #619

Merged
merged 1 commit into from
Jun 3, 2024
Merged

feat: [DX-1395] Add ToggleButton #619

merged 1 commit into from
Jun 3, 2024

Conversation

witwash
Copy link
Contributor

@witwash witwash commented May 31, 2024

Summary

  • added OptimusToggleButton
  • added OptimusToggleButton story
Preview
CleanShot.2024-05-31.at.13.30.55.mp4

Testing steps

  1. Open the Toggle Button story
  2. Test Toggle Button using exposed knobs in both dark and light themes.

Follow-up issues

None

Check during review

  • Verify against Jira issue.
  • Is the PR over 300 additions? Consider rejecting it with advice to split it. Is it over 500 additions? It should definitely be rejected.
  • Unused code removed.
  • Build passing.
  • Is it a bug fix? Check that it is covered by a proper test (unit or integration).

@witwash witwash requested a review from ookami-kb May 31, 2024 11:32
@witwash witwash marked this pull request as ready for review May 31, 2024 11:32
@witwash witwash requested a review from a team as a code owner May 31, 2024 11:32
@witwash witwash merged commit 31d7fbd into master Jun 3, 2024
7 checks passed
@witwash witwash deleted the toggle-button branch June 3, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ookami-kb ookami-kb ookami-kb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@witwash @ookami-kb