Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add success button variant #617

Merged
merged 4 commits into from
May 30, 2024
Merged

feat: Add success button variant #617

merged 4 commits into from
May 30, 2024

Conversation

witwash
Copy link
Contributor

@witwash witwash commented May 30, 2024 •
edited
Loading

Summary

  • added success button variant
  • refactored the OptimuButtonVariant and moved most of it to the BaseButtonVariant
  • made some properties optional

Testing steps

Most of the changes would not be visible. Test if the buttons are not broken and their variant are correct.

Follow-up issues

  • Add isLoading state
  • Add OptimusToggleButton

Check during review

  • Verify against Jira issue.
  • Is the PR over 300 additions? Consider rejecting it with advice to split it. Is it over 500 additions? It should definitely be rejected.
  • Unused code removed.
  • Build passing.
  • Is it a bug fix? Check that it is covered by a proper test (unit or integration).

@witwash witwash requested a review from ookami-kb May 30, 2024 10:53
@witwash witwash marked this pull request as ready for review May 30, 2024 10:53
@witwash witwash requested a review from a team as a code owner May 30, 2024 10:53
@witwash witwash merged commit 9795dc3 into master May 30, 2024
6 checks passed
@witwash witwash deleted the refactor-base-button branch May 30, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ookami-kb ookami-kb ookami-kb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@witwash @ookami-kb