Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [DX-1787] Update button inside padding #616

Merged
merged 1 commit into from
May 30, 2024
Merged

feat: [DX-1787] Update button inside padding #616

merged 1 commit into from
May 30, 2024

Conversation

witwash
Copy link
Contributor

@witwash witwash commented May 29, 2024

Summary

  • added padding that depends on the button size

Testing steps

  1. Open Button story
  2. Test button with leading icon/trailing icon/badge.
  3. Check all sizes.
  4. The button's content should be aligned to the center.
Preview
CleanShot.2024-05-29.at.17.28.00.mp4

Follow-up issues

None

Check during review

  • Verify against Jira issue.
  • Is the PR over 300 additions? Consider rejecting it with advice to split it. Is it over 500 additions? It should definitely be rejected.
  • Unused code removed.
  • Build passing.
  • Is it a bug fix? Check that it is covered by a proper test (unit or integration).

@witwash witwash marked this pull request as ready for review May 29, 2024 15:46
@witwash witwash requested a review from a team as a code owner May 29, 2024 15:46
@witwash witwash requested a review from ookami-kb May 29, 2024 15:46
@witwash
Copy link
Contributor Author

witwash commented May 30, 2024

@ookami-kb, we might need to update the rights because I can't merge without @chaeMil's review

@witwash witwash enabled auto-merge (squash) May 30, 2024 11:18
@witwash witwash disabled auto-merge May 30, 2024 11:18
@witwash witwash merged commit 3f878b5 into master May 30, 2024
7 checks passed
@witwash witwash deleted the button-padding branch May 30, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ookami-kb ookami-kb ookami-kb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@witwash @ookami-kb