Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: [DX-1155] Update OptimusIcon #536

Merged
merged 3 commits into from
Feb 7, 2024
Merged

feat!: [DX-1155] Update OptimusIcon #536

merged 3 commits into from
Feb 7, 2024

Conversation

witwash
Copy link
Contributor

@witwash witwash commented Feb 5, 2024 •
edited
Loading

Summary

  1. Updated OptimusIcon color types
  2. [BREAKING CHANGE] removed subtle variant for the OptimusIcon
  3. [BREAKING CHANGE] removed OptimusSupplementaryIcon
  4. Updated story

Testing steps

  1. Open icon story
  2. Check whether icons are displayed correctly in light and dark theme

Follow-up issues

None

Check during review

  • Verify against Jira issue.
  • Is the PR over 300 additions? Consider rejecting it with advice to split it. Is it over 500 additions? It should definitely be rejected.
  • Unused code removed.
  • Build passing.
  • Is it a bug fix? Check that it is covered by a proper test (unit or integration).

@witwash witwash marked this pull request as ready for review February 6, 2024 16:22
@witwash witwash requested a review from a team February 6, 2024 16:22
@witwash witwash merged commit 8c2ae9f into master Feb 7, 2024
6 checks passed
@witwash witwash deleted the DX-1155 branch February 7, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ookami-kb ookami-kb ookami-kb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@witwash @ookami-kb