Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [DX-723] Migrate to typography tokens #531

Merged
merged 5 commits into from
Jan 30, 2024
Merged

feat: [DX-723] Migrate to typography tokens #531

merged 5 commits into from
Jan 30, 2024

Conversation

witwash
Copy link
Contributor

@witwash witwash commented Jan 29, 2024 •
edited
Loading

Summary

  • removed old presets and replaced them with typography tokens
  • updated components to use matching tokens (some of them are missing the definition in the design and I'll fixed them 1 by 1 in followups)
  • updated stories

Testing steps

This PR is touching almost all components. Check the overall look of the storybook stories and I'll fix them 1 by 1 in the follow-ups if needed.

Follow-up issues

Some of the components were using styles not defined in design and I need to contact design team and update them accordingly.

Check during review

  • Verify against Jira issue.
  • Is the PR over 300 additions? Consider rejecting it with advice to split it. Is it over 500 additions? It should definitely be rejected.
  • Unused code removed.
  • Build passing.
  • Is it a bug fix? Check that it is covered by a proper test (unit or integration).

@witwash witwash added the ignore-size Ignore the size of this PR label Jan 29, 2024
@witwash witwash marked this pull request as ready for review January 30, 2024 12:05
@witwash witwash requested a review from a team January 30, 2024 12:05
ookami-kb
ookami-kb approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@ookami-kb ookami-kb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think it should be a breaking change.

@witwash witwash merged commit 5345ff8 into master Jan 30, 2024
6 checks passed
@witwash witwash deleted the DX-723 branch January 30, 2024 12:16
@witwash
Copy link
Contributor Author

witwash commented Jan 30, 2024

Shoot, I merged it before seeing your comment :-/

@witwash
Copy link
Contributor Author

witwash commented Jan 30, 2024

@ookami-kb,
presets.dart wasn't exposed so it isn't breaking there. One thing that could be breaking is creating optimusMaterialTheme with its baseTextStyle, because bodyMedium has defined fontSize 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ookami-kb ookami-kb ookami-kb approved these changes

Assignees
No one assigned
Labels
ignore-size Ignore the size of this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@witwash @ookami-kb