Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [DX-724] Migrate to sizes tokens #530

Merged
merged 5 commits into from
Jan 29, 2024
Merged

feat: [DX-724] Migrate to sizes tokens #530

merged 5 commits into from
Jan 29, 2024

Conversation

witwash
Copy link
Contributor

@witwash witwash commented Jan 26, 2024

Summary

  1. Replaced sizes with according tokens.
  2. Added todos for components that need more info from the design team.

Testing steps

This one is touching almost every component so it would be better to browse through every story and check if components don't look off.

Follow-up issues

Fixing stuff from todo's.

Check during review

  • Verify against Jira issue.
  • Is the PR over 300 additions? Consider rejecting it with advice to split it. Is it over 500 additions? It should definitely be rejected.
  • Unused code removed.
  • Build passing.
  • Is it a bug fix? Check that it is covered by a proper test (unit or integration).

@witwash witwash added the ignore-size Ignore the size of this PR label Jan 26, 2024
@witwash witwash marked this pull request as ready for review January 29, 2024 10:48
@witwash witwash requested a review from a team January 29, 2024 10:48
@witwash witwash merged commit 683cc29 into master Jan 29, 2024
6 checks passed
@witwash witwash deleted the DX-724 branch January 29, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-size Ignore the size of this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants