Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [DX-1033] Hide helper message in disabled input #523

Merged
merged 1 commit into from
Jan 23, 2024
Merged

feat: [DX-1033] Hide helper message in disabled input #523

merged 1 commit into from
Jan 23, 2024

Conversation

witwash
Copy link
Contributor

@witwash witwash commented Jan 23, 2024 •
edited
Loading

Summary

Updated the design of the input field wrapper. Disabled input should not have either the error or helper message underneath it.

Testing steps

  1. Open the Input Field story
  2. Add helper message/error
  3. Disable/Enable the component and check if the component is following the design decision.

Follow-up issues

None

Check during review

  • Verify against Jira issue.
  • Is the PR over 300 additions? Consider rejecting it with advice to split it. Is it over 500 additions? It should definitely be rejected.
  • Unused code removed.
  • Build passing.
  • Is it a bug fix? Check that it is covered by a proper test (unit or integration).

@witwash witwash marked this pull request as ready for review January 23, 2024 10:38
@witwash witwash requested a review from a team January 23, 2024 10:38
@witwash witwash merged commit e0a9d91 into master Jan 23, 2024
7 checks passed
@witwash witwash deleted the DX-1033 branch January 23, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ookami-kb ookami-kb ookami-kb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@witwash @ookami-kb