Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update OptimusSlidableAction #517

Merged
merged 1 commit into from
Jan 22, 2024
Merged

feat: Update OptimusSlidableAction #517

merged 1 commit into from
Jan 22, 2024

Conversation

witwash
Copy link
Contributor

@witwash witwash commented Jan 18, 2024 •
edited
Loading

Summary

  • Made an onTap nullable in OptimusSlidableAction. This will reduce the redundant code.

Testing steps

None

Follow-up issues

None

Check during review

  • Verify against Jira issue.
  • Is the PR over 300 additions? Consider rejecting it with advice to split it. Is it over 500 additions? It should definitely be rejected.
  • Unused code removed.
  • Build passing.
  • Is it a bug fix? Check that it is covered by a proper test (unit or integration).

@witwash witwash requested a review from a team January 18, 2024 17:59
@witwash witwash merged commit 7d960dc into master Jan 22, 2024
8 checks passed
@witwash witwash deleted the slidable-refactor branch January 22, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ookami-kb ookami-kb ookami-kb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@witwash @ookami-kb